infrequent Null Pointer exception in edit details dialog shown for rename

[rempel]

In frequent null pointer exception during rename using the edit details dialog

slot is not renamed if you save the edited details then exit using close you will ask to save or discard the changes (which should not be necessary).

So there is something wrong before the close action is executed.

Stack trace: java.lang.NullPointerException? java.lang.NullPointerException?

at

org.mpg.dcts.promot.dialogs.SlotDetailsDialog?$CloseAction?.doIt(SlotDetailsDialog?.java:1091)

at org.mpg.dcts.promot.vizedit.Editor$1$1.run(Editor.java:262)

code referenced in stack-trace is: ce.getLayerManager().getActiveLayer().presentationFor(node).propertyChange(new PropertyChangeEvent?(node, "model", null, null));

ce most likely not null because than the NPE should be already thrown in (SlotDetailsDialog?.java:1035): moduleClass=((ModuleGraphModel?)ce.getGraphModel()).getModel();

so most likely node is null or for other reasons presentationFor(node) returns null

[rempel]

pressing the Save button and getting a save/discard/cancel optionPanel happens if save triggers a reload. until the reload is completed the model is changed (unclear how this is detected within SlotDetailsDialog?) and you will get this message.

so save before exit and close (exit the dialog) only if reload is finished (visible by not getting the option to save/discard; cancel if you are asked).

combination of change class and rename are having exactly this problem, so split them into two edits until problems with reloading are resolved.

[rempel]

status (reloading /IDLE) is now displayed in the editor. for changing class and name there are two reloads. after the last is finished close should work as expected. (hitting save means that the model will be update at this moment, maybe it would be nice to disable close until everything is safe again.)

[rempel]

seems to be fixed. current rev [8721]